[Spread-users] Last Call for Spread 4.0.0rc2 bugs

[Jonathan Stanton]

I've committed a version of your fix for the tv_usec bug to spread 4 (the 3.17 
branch doens't have this bug)

Thanks,

Jonathan

On Thu, Oct 19, 2006 at 11:33:10AM -0400, Daniel F. Savarese wrote:
> 
> In message <20061019142758.GE2003 at cnds.jhu.edu>, Jonathan Stanton writes:
> >We are finalizing the Spread 4.0.0 release and wanted to check if anyone 
> >has any outstanding problems with the test release (4.0.0rc2) that have 
> >not already been reported. 
> 
> I see that a recently reported bug in sp.c was fixed in r355
> (http://commedia.cnds.jhu.edu/pipermail/spread-cvs/2006-October/000293.html)
> but I can't find an archived commit message applying the fix for a typo in 
> the initialization of sel_time.tv_usec that someone reported a while back.
> I've attached the combined patch that I've been using to fix both problems.
> Since your trunk version of sp.c has changed, the patch won't apply cleanly
> anymore, but it shows the locations (with surrounding context) of the three
> sel_time.tv_sec assignments that should read sel_time.tv_usec.
> 
> daniel

Content-Description: SP_get_vs_sets_info_and_select_bugfix.4.0rc2.patch
> --- libspread/sp.c.orig	2006-03-02 16:28:11.000000000 -0500
> +++ libspread/sp.c	2006-08-11 12:22:06.000000000 -0400
> @@ -271,14 +271,14 @@
>                  FD_SET(s, &fixed_rset);
>                  rset = fixed_rset;
>                  sel_time.tv_sec = wait_time.sec;
> -                sel_time.tv_sec = wait_time.usec;
> +                sel_time.tv_usec = wait_time.usec;
>                  while( ((num_ready = select(s+1, &rset, NULL, NULL, &sel_time)) == -1) && ((sock_errno == EINTR) || (sock_errno == EAGAIN) || (sock_errno == EWOULDBLOCK)) )
>                  {
>                          temp_time = E_get_time();
>                          if (E_compare_time(temp_time, target_time) < 0 ) {
>                                  wait_time = E_sub_time(target_time, temp_time);
>                                  sel_time.tv_sec = wait_time.sec;
> -                                sel_time.tv_sec = wait_time.usec;
> +                                sel_time.tv_usec = wait_time.usec;
>                          } else {
>                                  printf("recv_nointr_timeout: Timed out when interrupted\n");
>                                  sock_set_errno( ERR_TIMEDOUT );
> @@ -328,7 +328,7 @@
>          target_time = E_add_time(start_time, *time_out);
>          wait_time = *time_out;
>          sel_time.tv_sec = wait_time.sec;
> -        sel_time.tv_sec = wait_time.usec;
> +        sel_time.tv_usec = wait_time.usec;
>          /* set file descriptor to non-blocking */
>          on = 1;
>          ret_ioctl = ioctl( s, FIONBIO, &on);
> @@ -352,7 +352,7 @@
>              if (E_compare_time(temp_time, target_time) < 0 ) {
>                  wait_time = E_sub_time(target_time, temp_time);
>                  sel_time.tv_sec = wait_time.sec;
> -                sel_time.tv_sec = wait_time.usec;
> +                sel_time.tv_usec = wait_time.usec;
>              } else {
>                  Alarmp( SPLOG_WARNING, SESSION, "connect_nointr_timeout: connect interrupted and select wait timesout during transient error: %s\n", sock_strerror(sock_errno));
>                  close(s);
> @@ -1866,7 +1866,7 @@
>          local_vs_set_offset += SP_get_first_vs_set_offset_memb_mess();
>          memb_offset = SP_get_first_vs_set_offset_memb_mess();
>  
> -        for ( i=0; i < num_vs_sets; i++, vs_sets++ )
> +        for ( i=0; i < actual_num_vs_sets; i++, vs_sets++ )
>          {
>                  if (memb_offset == local_vs_set_offset)
>                          *my_vs_set_index = i;

> _______________________________________________
> Spread-users mailing list
> Spread-users at lists.spread.org
> http://lists.spread.org/mailman/listinfo/spread-users


-- 
-------------------------------------------------------
Jonathan R. Stanton         jonathan at cs.jhu.edu
Dept. of Computer Science   
Johns Hopkins University    
-------------------------------------------------------