[Spread-cvs] cvs commit: spread/daemon Changelog Readme.txt groups.c
jonathan at spread.org
jonathan at spread.org
Tue Jul 12 09:50:34 EDT 2011
jonathan 04/10/29 11:01:03
Modified: daemon Changelog Readme.txt groups.c
Log:
Merge branch_3_17 changes.
removed assignment from assert() call.
Updated Changelog and Readme.txt files.
Revision Changes Path
1.5 +89 -0 spread/daemon/Changelog
Index: Changelog
===================================================================
RCS file: /storage/cvsroot/spread/daemon/Changelog,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- Changelog 16 Apr 2004 16:27:09 -0000 1.4
+++ Changelog 29 Oct 2004 15:01:03 -0000 1.5
@@ -1,3 +1,92 @@
+Fri Oct 29 10:53:03 2004 Jonathan Stanton <jonathan at cnds.jhu.edu>
+
+ * groups.c: Move assignment of this_group out of assert() call.
+
+October 15, 2004 Ver 3.17.3
+---------------------------
+
+1) Fix memory leak in Skiplist. Reported by Taj Khattra, patch by Theo
+ Schlossnagle.
+
+2) spuser,spflooder, and spmonitor fixed to print correct name in help.
+ Patch by Daniel Rall.
+
+3) Fix incorrect alarm printing where WARNING messages generated by
+ older Alarm() interface were not printed.
+
+4) Modify monitor so it will run correctly on Windows. This was done
+ by modifying monitor.c so it can also build as a threaded program
+ and on windows will use multiple threads to send/recv updates and
+ get user imput. (A POSIX thread option is also added).
+
+5) Fix a bug in the Windows build using VC++ of thread-safe
+ libtspread.lib. Bug and fix by Jacob Green.
+
+6) Fix bug in libspread where if the groups array or message body
+ passed to SP_recv* was too small, the mess_type field returned
+ would be truncated and the sender field was not returned. They are
+ both now returned correctly. Bug report and partial fix provided
+ by John Schultz.
+
+7) Fix bug where SP_Join and SP_Leave do not report an error if a
+ group name is too long (instead they truncated it) Reported with
+ fix by David Parker. ** Warning, this could break buggy
+ applications who use long groups and assume the name is truncated.
+
+8) Cleanup compile warnings where E_queue() used with no-parameter
+ functions (not all uses fixed) and fix incorrect use of signed int
+ with strlen().
+
+9) Fix few cases in flooder.c and user.c that did not use the defined
+ MAX_MESSLEN constant. Tested to verify that increasing
+ MAX_SCATTER_ELEMENTS in scatter.h and the MAX_MESSLEN defines in
+ user.c and flooder.c is sufficient to support arbitrarily large
+ message sizes with Spread. This is NOT recommended, but several
+ people do it anyway :-)
+
+10) Add new option to spflooder. The -n option allows a fixed "number
+ of members" to be set. This then activates a multi-sender flow
+ control algorithm to allow flooding tests with several
+ senders. All of the processes need to join the group (i.e. they
+ cannot be -wo (write-only)) but not all processes have to send.
+ This allows easy testing with differing numbers of senders (just
+ change how many spflooders start with -ro and how many do not).
+
+11) Make E_delay() work on Win32.
+
+12) Added check that a segment using localhost (i.e. 127.0.0.255) is
+ NOT in a spread.conf with any other segments using real IP
+ addresses. This configuration will not work correctly and is
+ usually because the example localhost configuration provided with
+ Spread is added to. This check will cause the daemon to exit
+ immediately after parsing the config file.
+
+13) Add new Alarm priority flag to print a line with no datestamp (for
+ multi-line output).
+
+14) Fix bug where if more then 22 daemons start at the same time, some
+ will crash or the membership will not complete correctly. This bug
+ was reported by several people including Jesse Noller.
+
+15) Fix Java spread connection problem where several threaded
+ connections from same process cause unexpected connection
+ failures. Reported by Brian Moseley, idea of fix by Ryan Caudy,
+ patch by Jonathan Stanton.
+
+16) Fix EVS bug where AGREED messages may be delivered before a
+ transitional signal on some daemons and after it on others. Bug
+ found and patch created by Ryan Caudy.
+
+17) Make SP_connect_timeout() calls non-blocking for the actual
+ 'connect()' call. This should fix the issue reported by Shlomi
+ Yaakobovich where a hung daemon causes new connections to also
+ hang in connect. Also includes slight cleanup of connect code
+ path.
+
+18) Add new Windows VC++.Net project files to
+ daemon/win32_msvc_net. The current project files in daemon/win32
+ remain as they can be used in VC++ (version 6).
+
March 5, 2004 Ver 3.17.2:
--------------
1) Fix daemon quit when multiple interfaces are configured as "D" daemon
1.70 +2 -57 spread/daemon/Readme.txt
Index: Readme.txt
===================================================================
RCS file: /storage/cvsroot/spread/daemon/Readme.txt,v
retrieving revision 1.69
retrieving revision 1.70
diff -u -r1.69 -r1.70
--- Readme.txt 14 Oct 2004 17:35:23 -0000 1.69
+++ Readme.txt 29 Oct 2004 15:01:03 -0000 1.70
@@ -49,64 +49,9 @@
| Version 3.17.3 built 15/October/2004 |
\===========================================================================/
-October 15, 2004 Ver 3.17.3
+XXX XX, 2004 Ver 3.17.x
---------------------------
-
-1) Fix memory leak in Skiplist. Reported by Taj Khattra, patch by Theo
- Schlossnagle.
-2) spuser,spflooder, and spmonitor fixed to print correct name in help.
- Patch by Daniel Rall.
-3) Fix incorrect alarm printing where WARNING messages generated by
- older Alarm() interface were not printed.
-4) Modify monitor so it will run correctly on Windows. This was done by
- modifying monitor.c so it can also build as a threaded program and
- on windows will use multiple threads to send/recv updates and get
- user imput. (A POSIX thread option is also added).
-5) Fix a bug in the Windows build using VC++ of thread-safe libtspread.lib.
- Bug and fix by Jacob Green.
-6) Fix bug in libspread where if the groups array or message body passed
- to SP_recv* was too small, the mess_type field returned would be truncated
- and the sender field was not returned. They are both now returned correctly.
- Bug report and partial fix provided by John Schultz.
-7) Fix bug where SP_Join and SP_Leave do not report an error if a group name
- is too long (instead they truncated it) Reported with fix by David Parker.
- ** Warning, this could break buggy applications who use long groups and
- assume the name is truncated.
-8) Cleanup compile warnings where E_queue() used with no-parameter functions
- (not all uses fixed) and fix incorrect use of signed int with strlen().
-9) Fix few cases in flooder.c and user.c that did not use the defined MAX_MESSLEN
- constant. Tested to verify that increasing MAX_SCATTER_ELEMENTS in scatter.h
- and the MAX_MESSLEN defines in user.c and flooder.c is sufficient to support
- arbitrarily large message sizes with Spread. This is NOT recommended, but
- several people do it anyway :-)
-10) Add new option to spflooder. The -n option allows a fixed "number of members"
- to be set. This then activates a multi-sender flow control algorithm to allow
- flooding tests with several senders. All of the processes need to join the
- group (i.e. they cannot be -wo (write-only)) but not all processes have to send.
- This allows easy testing with differing numbers of senders (just change how
- many spflooders start with -ro and how many do not).
-11) Make E_delay() work on Win32.
-12) Added check that a segment using localhost (i.e. 127.0.0.255) is NOT in a
- spread.conf with any other segments using real IP addresses. This configuration
- will not work correctly and is usually because the example localhost configuration
- provided with Spread is added to. This check will cause the daemon to exit
- immediately after parsing the config file.
-13) Add new Alarm priority flag to print a line with no datestamp (for multi-line output).
-14) Fix bug where if more then 22 daemons start at the same time, some will crash or the
- membership will not complete correctly. This bug was reported by several people
- including Jesse Noller.
-15) Fix Java spread connection problem where several threaded connections from same
- process cause unexpected connection failures. Reported by Brian Moseley,
- idea of fix by Ryan Caudy, patch by Jonathan Stanton.
-16) Fix EVS bug where AGREED messages may be delivered before a transitional signal
- on some daemons and after it on others. Bug found and patch created by
- Ryan Caudy.
-17) Make SP_connect_timeout() calls non-blocking for the actual 'connect()' call.
- This should fix the issue reported by Shlomi Yaakobovich where a hung daemon
- causes new connections to also hang in connect. Also includes slight cleanup
- of connect code path.
-18) Add new Windows VC++.Net project files to daemon/win32_msvc_net. The current
- project files in daemon/win32 remain as they can be used in VC++ (version 6).
+See changes in Changelog file.
SOURCE INSTALL:
---------------
1.18 +2 -1 spread/daemon/groups.c
Index: groups.c
===================================================================
RCS file: /storage/cvsroot/spread/daemon/groups.c,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -r1.17 -r1.18
--- groups.c 23 Sep 2004 23:15:18 -0000 1.17
+++ groups.c 29 Oct 2004 15:01:03 -0000 1.18
@@ -1555,7 +1555,8 @@
changed = 0;
orig_grp = NULL;
- assert( NULL != (this_group = (group *)(sl_getlist(indices[0]->groups)->data)) );
+ this_group = (group *)(sl_getlist(indices[0]->groups)->data);
+ assert( NULL != this_group );
orig_grp = sl_find( &GroupsList, this_group->name, &top_iter);
if( orig_grp == NULL )
More information about the Spread-cvs
mailing list